Overriding retry policy for SMS high priority #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I think that this retry is for when, for example, the boto call fails. If celery itself crashes or is killed outright then I think we have to rely on the SQS retry timeout |
sastels
reviewed
Oct 26, 2023
| (EMAIL_TYPE, PRIORITY, 48, 300), | ||
| (SMS_TYPE, BULK, 48, 300), | ||
| (SMS_TYPE, NORMAL, 48, 300), | ||
| (SMS_TYPE, PRIORITY, 48, 26), |
There was a problem hiding this comment.
instead of hard coding these values we could pull them from RETRY_POLICY_DEFAULT and RETRY_POLICY_HIGH
There was a problem hiding this comment.
Changed it to the config values. 👍
…' into feat/decrease-retry-for-sms-high
whabanks
approved these changes
Nov 6, 2023
sastels
approved these changes
Nov 6, 2023
app/celery/provider_tasks.py
Outdated
| @@ -112,6 +113,7 @@ def _deliver_sms(self, notification_id): | |||
| notification = notifications_dao.get_notification_by_id(notification_id) | |||
| if not notification: | |||
| raise NoResultFound() | |||
| # raise Exception("Trigger artificial Celery retry") | |||
| @@ -43,7 +43,7 @@ | |||
| "-l", | |||
| "DEBUG", | |||
| "-Q", | |||
| "database-tasks,-priority-database-tasks.fifo,-normal-database-tasks,-bulk-database-tasks,job-tasks,notify-internal-tasks,periodic-tasks,priority-tasks,bulk-tasks,reporting-tasks,research-mode-tasks,retry-tasks,send-sms-tasks,send-email-tasks,service-callbacks,delivery-receipts", | |||
| "database-tasks,-priority-database-tasks.fifo,-normal-database-tasks,-bulk-database-tasks,job-tasks,notify-internal-tasks,periodic-tasks,priority-tasks,normal-tasks,bulk-tasks,reporting-tasks,research-mode-tasks,retry-tasks,send-sms-tasks,send-sms-high,send-sms-medium,send-sms-low,send-throttled-sms-tasks,send-email-high,send-email-medium,send-email-low,send-email-tasks,service-callbacks,delivery-receipts", | |||
Yes that is the strategy I use at the moment, i.e. trigger an exception for every send of SMS so that I can test the retries. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
These changes override the retry policy for SMS high priority.
In case where the Celery workers went down, we want to retry the high priority notifications within a 1 minute time frame to honor its SLO.
Test instructions | Instructions pour tester la modification
No tests at the moment; working on it.
Release Instructions | Instructions pour le déploiement
Test in staging by running performance tests and emulate spikes of notifications bulk that will bring up and down Celery workers.
Reviewer checklist | Liste de vérification du réviseur
This is a suggested checklist of questions reviewers might ask during their
review | Voici une suggestion de liste de vérification comprenant des questions
que les réviseurs pourraient poser pendant leur examen :
une baisse de la quantité de code couvert par les tests automatisés?
fonctionnalité existante?
modification de la politique de confidentialité?
préoccupations liées à la sécurité?
façon importante la performance?
risque d’utiliser des dépendances ajoutées?
setup, etc.) | Faudra-t-il mettre à jour la documentation à la suite de ce
changement (fichier README, etc.)?